xmlreader: getAttributeNo()/getAttributeNs() return null, not an empty string#5674
Closed
lacatoire wants to merge 1 commit into
Closed
xmlreader: getAttributeNo()/getAttributeNs() return null, not an empty string#5674lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both descriptions said they return an empty string when the attribute is missing or the reader is not positioned on an element node. They actually return
null.Verified in php-src: the stubs declare
?string, and inext/xmlreader/php_xmlreader.cretcharstarts atNULLandreturn_valueis only written viaRETVAL_STRINGwhen the attribute exists, so it staysnullotherwise.